GenJ 3.x

Anything GenJ related from the developer's point of view

GenJ 3.x

Postby Paul_R » Fri Feb 26, 2010 14:54:33

Hi Nils

I like the way this is heading :D , can I suggest 'Detail' rather than 'Type' as a column header though? ('Event' or 'Type' would seem right for the first column)

eventtable.jpg
eventtable.jpg (11.22 KiB) Viewed 1545 times


Paul
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England

Re: GenJ 3.x

Postby nmeier » Fri Feb 26, 2010 17:23:35

Those with svn know-how have the advantage :)

sure, 'detail' it is

This is basically undefined for most event-like structures in Gedcom - but exists for OCCUpation (other event like attributes with DATEs are not necessarily going to show up in the list of events).

Cheers
Nils
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby FrançoisMz » Fri Feb 26, 2010 18:44:17

Hi Nils,

Yes, it does look good like that.
In the reference area, the third column is titled "*". What does it correspond to ? Are you planning to include something in this column ?

A small trouble in entity & tree blueprints: when I try to display separate jurisdictions, the problem is that jurisdiction=0 returns the first available jurisdiction and that jurisdiction=1 returns the second jurisdiction, so there's no way to display the first jurisdiction!
I have fixed this on my local svn copy by adding "-1" in the right place of files BlueprintRenderer and PropertyRenderer (see in the code below when i>0).
Code: Select all
    private String getText(PropertyPlace place) {
      Object j = attributes.get("jurisdiction");
      // index?
      if (j!=null) {
       
        // 0 = first available
        if ("0".equals(j))
          return place.getFirstAvailableJurisdiction();

        // i>0
        String result = null;
        try {
            result = place.getJurisdiction(Integer.parseInt(j.toString())-1);
        } catch (Throwable t) {
        }
        return result==null ? "" : result;
      }
     
      // all
      return place.getFirstAvailableJurisdiction();
    }


Would you be ok to integrate that in svn ?

Also in BlueprintRenderer.java (the code above), the "all" variant returns the first available jurisdiction, whereas in PropertyRenderer.java, it returns all jurisdictions (getDisplayValue). Should we fix that as well ?

Cheers
François
User avatar
FrançoisMz
 
Posts: 127
Joined: Fri Jan 29, 2010 17:05:02
Location: France

Re: GenJ 3.x

Postby nmeier » Sat Feb 27, 2010 1:54:18

Hi Francois

the * is the displayValue of the target - so it'

property - that references something
Reference - the record that's reference
* - the display value of that record

could be improved :)

for the jurisdictions - yes, that should be different, good thinking.

I wanted to go with first jurisdiction only by default (the values are otherwise too big by default). How about this:

Code: Select all
    private String getText(PropertyPlace place) {
      Object j = attributes.get("jurisdiction");
      // index?
      if (j!=null) {
       
        // 0 = first available
        if ("0".equals(j))
          return place.getFirstAvailableJurisdiction();

        // all = first available
        if ("all".equals(j))
          return place.getDisplayValue();

        // i>0
        String result = null;
        try {
            result = place.getJurisdiction(Integer.parseInt(j.toString())-1);
        } catch (Throwable t) {
        }
        return result==null ? "" : result;
      }
     
      // default is first only
      return place.getFirstAvailableJurisdiction();
    }



Cheers
Nils
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby FrançoisMz » Sat Feb 27, 2010 4:24:35

Hi Nils,

OK, I understand the "*". Perhaps not easy to improve if you want to find a common rule for all properties.

For the jurisdictions, I realized afterwards I didn't express it exactly what I meant: the need to display the first jurisdiction separately is of course only if you want to display first jurisdiction + 1 or 2 other jurisdictions but NOT all of them. Anyway, you got it (always, my same need for "hamlet, town"... :) ).

I also thought after sending my post that your choice to display the first available jurisdiction as default value in the blueprints is the obvious and only one. We don't want to bother people with the long format in the entity or tree view (I was about to go to bed when I wrote that!).

I really like your proposal for the "all" option, leaving first available jurisdiction by default. Good idea.

Cheers
François
User avatar
FrançoisMz
 
Posts: 127
Joined: Fri Jan 29, 2010 17:05:02
Location: France

Re: GenJ 3.x

Postby nmeier » Sat Feb 27, 2010 11:39:11

Hi François

ok, change for 2960245 is going into 3.0.1

Thanks!
Nils
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby Paul_R » Sat Feb 27, 2010 17:53:13

Nils, what's the plan for editing events in standard view - in situ in the 'table'?
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England

Re: GenJ 3.x

Postby nmeier » Sat Feb 27, 2010 19:26:02

Hi Paul

I'm still experimenting - we don't have in-situ editing in the normal table even though requested.
Problem is that the Gedcom editing features we have tend to use way more space than the cell used for rendering.

As you might have seen there are new buttons in the Editor for managing rows

events.png
events.png (52.57 KiB) Viewed 1515 times


I'll probably pull more up there into one central place. If in-situ editing of the actual data is too difficult it'll have to be a dialog for editing the event detail specifically.

Sounds ok?

Thanks
Nils
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby FrançoisMz » Sat Feb 27, 2010 19:26:24

Hi Nils,

nmeier wrote:ok, change for 2960245 is going into 3.0.1

Thanks for that.

Did I miss something or the standard editor view for family no longer displays the family members (parents / children) ?
I may be working with an incompletely built version, that's why I'm asking.

François
User avatar
FrançoisMz
 
Posts: 127
Joined: Fri Jan 29, 2010 17:05:02
Location: France

Re: GenJ 3.x

Postby nmeier » Sat Feb 27, 2010 19:28:22

Hi François

just a temporary thing - the stuff for FAMs on trunk is going to look similiar to how it looks for INDIs.

Cheers
Nils
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby FrançoisMz » Sat Feb 27, 2010 19:32:51

Nils,

OK, that was my assumption, but I was too lazy scanning the code for that...

Cheers
François
User avatar
FrançoisMz
 
Posts: 127
Joined: Fri Jan 29, 2010 17:05:02
Location: France

Re: GenJ 3.x

Postby Paul_R » Sun Feb 28, 2010 7:31:35

Nils, re dialog for editing events = lots more space and option to completely cancel rather than undo'ing individual field edits. Sounds good to me :D
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England

Re: GenJ 3.x

Postby Paul_R » Sun Mar 07, 2010 13:38:47

Nils

Is it possible to reset/clear the number of search results on file close?

e.g. In example.ged search for "meier" then close the file - the number of hits is still shown even though the results are cleared.

Paul
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England

Re: GenJ 3.x

Postby nmeier » Sun Mar 07, 2010 14:47:07

Is it possible to reset/clear the number of search results on file close?


done, thanks for pointing it out
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby Paul_R » Thu Mar 11, 2010 15:41:38

I have trouble immediately differentiating between the various sections in Edit View. IMHO they would benefit from some form of visual separation. Here's a cheesy (1990's Windows era!) idea:
editcoloursUntitled 1.jpg
editcoloursUntitled 1.jpg (35.08 KiB) Viewed 1480 times
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England

Re: GenJ 3.x

Postby nmeier » Thu Mar 11, 2010 18:03:35

:shock: as many will attest to - Nils is not a fan of colours - would have to be an option 8)

I'm thinking indenting the sections under the folding-symbol might already help

the feedback is appreciated though ;)
N
User avatar
nmeier
Site Admin
 
Posts: 2134
Joined: Mon Feb 02, 2004 21:35:23
Location: Toronto, Canada

Re: GenJ 3.x

Postby Paul_R » Thu Mar 11, 2010 18:17:31

LOL :D

I'm not a fan of colours either (I did say it was cheesy) but many of the eyes using GenJ will be of the more mature variety and that part of the screen is rather, er, busy. Indenting might fix it ;)

Paul
User avatar
Paul_R
 
Posts: 423
Joined: Mon Feb 02, 2009 9:10:27
Location: England


Return to Dev - Project, Design & Technology

Who is online

Users browsing this forum: No registered users and 1 guest